🐛 Fix: when editing text, the original Wiki syntax should be visible - using the class and not the class label. #509
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…using the class and not the class label.
Hipska
approved these changes
Jun 20, 2023
|
Guillaume will try to reproduce through a unit test before functional review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: when editing text, the original Wiki syntax should be visible - using the class and not the class label.
Try: in a text field of an object, refer to an object using wiki syntax, such as
[[WebServer::1]]. Save. So far, everything works as expected. In view mode, it will show a link to Web Server (id 1).However, when modifying the object (with the text field referencing Web Server 1), the text area will show the class label:
[[Web Server::1]]. Easily overlooked, but it breaks the wiki syntax when saving the object again.This PR changes the edit value to actually contain the original reference, using the class name instead of the class label.
See https://sourceforge.net/p/itop/tickets/1841/?limit=25#ddc5